Replace WPAuthenticator UI code in ChangeUsernameViewController.swift#25647
Open
crazytonyli wants to merge 5 commits into
Open
Replace WPAuthenticator UI code in ChangeUsernameViewController.swift#25647crazytonyli wants to merge 5 commits into
crazytonyli wants to merge 5 commits into
Conversation
Previously a suggestions reload always re-checked the current username row while the view model kept the previously selected suggestion. Render the checkmark from the stored selection instead, and drop the redundant local copy of the current username.
Collaborator
Generated by 🚫 Danger |
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 32577 | |
| Version | PR #25647 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 755d905 | |
| Installation URL | 7tpdifgpasuig |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 32577 | |
| Version | PR #25647 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 755d905 | |
| Installation URL | 0esjlvcndf8qo |
jkmassel
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
I recommend reviewing this PR commit by commit. The first commit is format-only.
Description
Part of removing WordPressAuthenticator. Some UI elements from WordPressAuthenticator are used in the app, which we don't need to.
Testing instructions
InlineEditableNameValueCellrows.